From 82c888bcbf17d5b85e6825d83040e9941ded4641 Mon Sep 17 00:00:00 2001 From: David Oberhollenzer Date: Thu, 21 Feb 2019 15:11:09 +0100 Subject: [PATCH] install: make sure package dependencies have no trivial cycles Signed-off-by: David Oberhollenzer --- main/cmd/install/collect.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/main/cmd/install/collect.c b/main/cmd/install/collect.c index f792725..78bbc1c 100644 --- a/main/cmd/install/collect.c +++ b/main/cmd/install/collect.c @@ -42,6 +42,13 @@ int collect_dependencies(int repofd, struct pkg_dep_list *list) buffer[dep.name_length] = '\0'; + if (strcmp((char *)buffer, it->name) == 0) { + fprintf(stderr, + "%s: package depends on itself\n", + it->name); + goto fail; + } + it->deps[i] = find_pkg(list, (char *)buffer); if (it->deps[i] == NULL) { it->deps[i] = append_pkg(list, (char *)buffer);