Roles: use environment instead of passing variable in shell command

roles/golang/tasks/main.yml

@@ -22,4 +22,6 @@
     mode: 0644
 
 - name: build dep util
-  shell: "GOPATH={{ gopath }} go get -v -u github.com/golang/dep/cmd/dep"
+  shell: "go get -v -u github.com/golang/dep/cmd/dep"
+  environment:
+    GOPATH: "{{ gopath }}"

roles/service-cpthook/tasks/main.yml

@@ -12,7 +12,9 @@
   notify: reload systemd
 
 - name: build cpthook binary
-  shell: 'GOPATH={{ gopath }} go get -u {{ cpthook_src }}'
+  shell: 'go get -u {{ cpthook_src }}'
+  environment:
+    GOPATH: "{{ gopath }}"
   notify: restart cpthook
 
 - name: configure cpthook systemd unit

roles/service-fastd-mesh/tasks/main.yml

@@ -98,7 +98,9 @@
   loop: "{{ meshes | subelements('fastd.nodes.instances') }}"
 
 - name: build fastd-exporter binary
-  shell: "GOPATH={{ gopath }} go get -v -u github.com/freifunk-darmstadt/fastd-exporter"
+  shell: "go get -v -u github.com/freifunk-darmstadt/fastd-exporter"
+  environment:
+    GOPATH: "{{ gopath }}"
   notify: restart fastd-exporter
 
 - name: copy vhost fastd_exporter.conf

roles/service-yanic/tasks/main.yml

@@ -45,10 +45,14 @@
     force: true
 
 - name: get required library versions
-  shell: "cd {{ gopath }}/src/{{ yanic_src }} && GOPATH={{ gopath }} {{ gopath }}/bin/dep ensure"
+  shell: "cd {{ gopath }}/src/{{ yanic_src }} && {{ gopath }}/bin/dep ensure"
+  environment:
+    GOPATH: "{{ gopath }}"
 
 - name: build Yanic binary
-  shell: 'GOPATH={{ gopath }} go install {{ gopath }}/src/{{ yanic_src }}'
+  shell: 'go install {{ gopath }}/src/{{ yanic_src }}'
+  environment:
+    GOPATH: "{{ gopath }}"
   notify: restart yanic
 
 - name: configure Yanic systemd unit